Refactor/cleanup experiments #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the retirement of most cardano-services, Blockfrost providers are now the only option for these, as updated here.
These address discovery and input resolvers are optimised for Blockfrost API providers, which are now hard coded.
mchappell
reviewed
Jan 28, 2025
apps/browser-extension-wallet/src/providers/ExperimentsProvider/types.ts
Outdated
Show resolved
Hide resolved
mchappell
reviewed
Jan 28, 2025
This was a temporary patch to workaround a backend issue
Allure Report
processReports: ❌ test report for 3961a370
|
* feat: pause polling while not using Lace * chore: update SDK packages * chore: update session timeout in env defaults --------- Co-authored-by: Michael Chappell <[email protected]>
|
mchappell
added a commit
that referenced
this pull request
Jan 28, 2025
* refactor: remove Blockfrost provider experiments With the retirement of most cardano-services, Blockfrost providers are now the only option for these, as updated here. * refactor: remove other Blockfrost experiments These address discovery and input resolvers are optimised for Blockfrost API providers, which are now hard coded. * refactor: cleanup extension storage experiment * refactor: drop DRepProvider active override This was a temporary patch to workaround a backend issue * feat: pause polling while not using Lace LW-12174 (#1673) * feat: pause polling while not using Lace * chore: update SDK packages * chore: update session timeout in env defaults --------- Co-authored-by: Michael Chappell <[email protected]> --------- Co-authored-by: Martynas <[email protected]> Co-authored-by: Michael Chappell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the retirement of most
cardano-services, Blockfrost providers are now the only option for these, as updated here. I've also cleaned up some of the other experiment code to reduce complexity.Testing
CI passing should be enough to verify this change